Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev -> main #967

Merged
merged 186 commits into from
Jan 4, 2025
Merged

dev -> main #967

merged 186 commits into from
Jan 4, 2025

Conversation

HamadaSalhab
Copy link
Contributor

No description provided.

creatorrr and others added 30 commits November 30, 2024 16:00
refactor(agents-api,integrations): Switch to uv from poetry
Add Sentry support to integration service
fix(agents-api): add sentry dsn env var to docker compose
feat: Add temporal metrics and setup prometheus and grafana correspondingly
chore: Update default heartbeat timeout
Copy link
Contributor

qodo-merge-pro-for-open-source bot commented Dec 18, 2024

CI Failure Feedback 🧐

(Checks updated until commit d054806)

Action: Typecheck

Failed stage: Typecheck [❌]

Failed test name: agents_api.common.protocol.sessions

Failure summary:

The action failed due to a type checking error in the get_chat_environment method within the file
agents_api/common/protocol/sessions.py. Specifically:

  • The return type of the method doesn't match its type annotation
  • The error occurred on line 115 of the file
  • The issue appears to be related to the return value structure which includes dictionary
    comprehensions for users and tools fields using model_dump()

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    1230:  [51/507] check agents_api.routers.sessions.metrics
    1231:  [52/507] check agents_api.activities.excecute_api_call
    1232:  [53/507] check agents_api.common.protocol.tasks
    1233:  [54/507] check agents_api.common.utils.messages
    1234:  [55/507] check agents_api.routers.sessions.router
    1235:  [56/507] check agents_api.common.protocol.developers
    1236:  [57/507] check agents_api.activities.task_steps.get_value_step
    1237:  [58/507] check agents_api.common.protocol.sessions
    1238:  FAILED: /home/runner/work/julep/julep/agents-api/.pytype/pyi/agents_api/common/protocol/sessions.pyi 
    1239:  /home/runner/work/julep/julep/agents-api/.venv/bin/python -m pytype.main --disable pyi-error --imports_info /home/runner/work/julep/julep/agents-api/.pytype/imports/agents_api.common.protocol.sessions.imports --module-name agents_api.common.protocol.sessions --platform linux -V 3.12 -o /home/runner/work/julep/julep/agents-api/.pytype/pyi/agents_api/common/protocol/sessions.pyi --analyze-annotated --nofail --none-is-not-bool --quick --strict-none-binding /home/runner/work/julep/julep/agents-api/agents_api/common/protocol/sessions.py
    1240:  /home/runner/work/julep/julep/agents-api/agents_api/common/protocol/sessions.py:115:9: error: in get_chat_environment: bad return type [bad-return-type]
    ...
    
    1255:  "users": [user.model_dump() for user in self.users],
    1256:  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1257:  "settings": settings,
    1258:  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1259:  "tools": [tool.model_dump() for tool in tools],
    1260:  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1261:  }
    1262:  ~~~~~~~~~
    1263:  For more details, see https://google.github.io/pytype/errors.html#bad-return-type
    ...
    
    1340:  [135/507] check migrations.migrate_1729114011_tweak_proximity_indices
    1341:  [136/507] check migrations.migrate_1733985509_add_columns_to_indices
    1342:  [137/507] check migrations.migrate_1721666295_developers_relation
    1343:  [138/507] check migrations.migrate_1709292828_presets
    1344:  [139/507] check migrations.migrate_1721576813_extended_tool_relations
    1345:  [140/507] check migrations.migrate_1717239610_token_budget
    1346:  [141/507] check migrations.migrate_1727235852_add_forward_tool_calls_option
    1347:  [142/507] check migrations.migrate_1731953383_create_files_relation
    1348:  ninja: build stopped: cannot make progress due to previous errors.
    1349:  Computing dependencies
    1350:  Generated API key since not set in the environment: 81843075268563201052292743775111
    1351:  Sentry DSN not found. Sentry will not be enabled.
    1352:  Analyzing 336 sources with 0 local dependencies
    1353:  Leaving directory '.pytype'
    1354:  ##[error]Process completed with exit code 1.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    HamadaSalhab and others added 13 commits December 18, 2024 15:47
    fix(agents-api): Session & system tool fixes
    Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
    chore(agents-api): Add `/healthz` endpoint
    Backtick in the colab link URL (decompiles as UTF8 %60 in the URL)
    
    This created an invalid path to the Google Colab File
    
    just a single backtick edit. that's it ⛵
    Copy link
    Contributor

    @standard-input standard-input bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    No issues flagged.
    Standard Input can make mistakes. Check important info.
    

    @HamadaSalhab HamadaSalhab merged commit 2ae5fe1 into main Jan 4, 2025
    11 of 14 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants