Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external link that are 'outlook protected' are opened internal. #262

Merged

Conversation

micw
Copy link
Contributor

@micw micw commented Feb 27, 2023

This also cleans up the link config so that the JSON and the actual config are identical.

@micw
Copy link
Contributor Author

micw commented Feb 27, 2023

fixes #240 for me

@fried-eggz
Copy link

Please approve this PR

@AdminOfOz
Copy link

I think there is a possibility this would also fix #256. It might also have some overlap with #265

@micw
Copy link
Contributor Author

micw commented Mar 10, 2023

Yes, it should also fix #265 and probably #256 - if I know the syntax of a "verification link", I could add it to the list of default external links.
(in general, it fixes the "external link" feature, so fixing particula links is just a matter of adding them to the correct list)

@jclsn
Copy link

jclsn commented Apr 5, 2023

Can someone please merge this? The issue is getting really annoying...

@AdminOfOz
Copy link

I checked @julian-alarcon commits and it looks like he is still somewhat active, but not nearly as active as he used to be. Could just be taking it easy for a little while. I think he linked his socials if you want to go as far as ping him on another platform.

Otherwise, I suggest cloning micw's feature branch or merging his changes locally on your computer and running it. It's what I've been doing for awhile now and it works great.

@jclsn
Copy link

jclsn commented Apr 7, 2023

@the-ryan-1 Okay, thank you. I will see after eastern.

@julian-alarcon julian-alarcon merged commit 5bbca82 into julian-alarcon:main Sep 15, 2023
3 checks passed
@micw
Copy link
Contributor Author

micw commented Sep 15, 2023

Great, thank you. Are you planing a new release soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants