Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust iOS thread QoS value #1110

Closed
wants to merge 3 commits into from
Closed

fix: Adjust iOS thread QoS value #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37726f5
use the global dispatch queue, with a specified QoS priority
navaronbracke Jul 1, 2024
14d3fb9
bump version & changelog
navaronbracke Jul 1, 2024
9959c42
switch from userInitiated to userInteractive
navaronbracke Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 5.1.2
* [iOS] Fixes an issue with priorities for the iOS scanner background thread.

## 5.1.1
* This release fixes an issue with automatic starts in the examples.

Expand Down
4 changes: 1 addition & 3 deletions ios/Classes/MobileScanner.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ public class MobileScanner: NSObject, AVCaptureVideoDataOutputSampleBufferDelega

var detectionSpeed: DetectionSpeed = DetectionSpeed.noDuplicates

private let backgroundQueue = DispatchQueue(label: "camera-handling")

var standardZoomFactor: CGFloat = 1

private var nextScanTime = 0.0
Expand Down Expand Up @@ -246,7 +244,7 @@ public class MobileScanner: NSObject, AVCaptureVideoDataOutputSampleBufferDelega
}
captureSession!.commitConfiguration()

backgroundQueue.async {
DispatchQueue.global(qos: .userInteractive).async {
guard let captureSession = self.captureSession else {
return
}
Expand Down
2 changes: 1 addition & 1 deletion ios/mobile_scanner.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
Pod::Spec.new do |s|
s.name = 'mobile_scanner'
s.version = '5.1.1'
s.version = '5.1.2'
s.summary = 'An universal scanner for Flutter based on MLKit.'
s.description = <<-DESC
An universal scanner for Flutter based on MLKit.
Expand Down
2 changes: 1 addition & 1 deletion macos/mobile_scanner.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
Pod::Spec.new do |s|
s.name = 'mobile_scanner'
s.version = '5.1.1'
s.version = '5.1.2'
s.summary = 'An universal scanner for Flutter based on MLKit.'
s.description = <<-DESC
An universal scanner for Flutter based on MLKit.
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: mobile_scanner
description: A universal barcode and QR code scanner for Flutter based on MLKit. Uses CameraX on Android, AVFoundation on iOS and Apple Vision & AVFoundation on macOS.
version: 5.1.1
version: 5.1.2
repository: https://github.com/juliansteenbakker/mobile_scanner

screenshots:
Expand Down
Loading