fix: do not hang on analyze image if there are no results #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Jan 5, 2025
| @@ -665,17 +665,31 @@ public class MobileScannerPlugin: NSObject, FlutterPlugin, FlutterStreamHandler, | |||
| } | |||
|
|
|||
| guard let barcodes: [VNBarcodeObservation] = request.results as? [VNBarcodeObservation] else { | |||
| DispatchQueue.main.async { | |||
There was a problem hiding this comment.
We apparently forgot these two :(
navaronbracke
commented
Jan 5, 2025
| "name": "barcode", | ||
| "data": barcodes.map({ $0.toMap(imageWidth: Int(ciImage.extent.width), imageHeight: Int(ciImage.extent.height), scanWindow: self.scanWindow) }), | ||
| ]) | ||
| DispatchQueue.main.async { |
There was a problem hiding this comment.
Adding a dispatch queue block, just in case (is the only relevant statement that didn't have it)
navaronbracke
commented
Jan 5, 2025
| @@ -29,6 +29,7 @@ | |||
| 33CC11132044BFA00003C045 /* MainFlutterWindow.swift in Sources */ = {isa = PBXBuildFile; fileRef = 33CC11122044BFA00003C045 /* MainFlutterWindow.swift */; }; | |||
| 58A22AC50A792ECA6D027507 /* Pods_RunnerTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 419C3BC9593F6DE903D740F0 /* Pods_RunnerTests.framework */; }; | |||
| F209F1436A19CBC32BFFB26A /* Pods_Runner.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = EEB40B96A6FFC92607527710 /* Pods_Runner.framework */; }; | |||
| 78A318202AECB46A00862997 /* FlutterGeneratedPluginSwiftPackage in Frameworks */ = {isa = PBXBuildFile; productRef = 78A3181F2AECB46A00862997 /* FlutterGeneratedPluginSwiftPackage */; }; | |||
There was a problem hiding this comment.
This is the same change for SPM as in #1273 but for MacOS, which I forgot to add.
navaronbracke
commented
Jan 5, 2025
| @@ -5,6 +5,24 @@ | |||
| <BuildAction | |||
| parallelizeBuildables = "YES" | |||
| buildImplicitDependencies = "YES"> | |||
| <PreActions> | |||
There was a problem hiding this comment.
This is the same change for SPM as in #1273 but for MacOS, which I forgot to add.
|
Working as intended now on macOS, and thus also on iOS, since both share the same code path for the fix. |
This was referenced Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1244