Better error message when matching null/undefined with toContain. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, calling
expect(null).toContain(42);
will throw an error
minijasminenode/lib/jasmine-1.3.1.js:1142
return haystack.indexOf(needle) >= 0;
^
TypeError: Cannot call method 'indexOf' of null
Since often the actual is the return value of some function, it can be non-obvious to find the defect. This change will show a more clear error message, pointing the user to the line in the test causing the failure instead of the line in the jasmine code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently thrown off by the error message
Since this happened when running a pretty large test suite, I was not immediately sure what had happened, nor which test case had actually failed. After some debugging it turned out that I had called expect(foo).toContain(bar), where foo was null. This pull request provides a better error message in this case:
I am not sure this is the correct repo to fix this in.
I also did not find any unit tests for the matchers, so I was not sure if I should add one for this change.
Please advice.