Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for v1.21.0 #2319

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Prep for v1.21.0 #2319

merged 5 commits into from
Oct 25, 2023

Conversation

odow
Copy link
Member

@odow odow commented Oct 24, 2023

docs/src/changelog.md Outdated Show resolved Hide resolved
@odow
Copy link
Member Author

odow commented Oct 24, 2023

I think the PolyJuMP failure is a problem. It looks like it tried to call

function _extract_function_and_set(expr::Expr)

@blegat
Copy link
Member

blegat commented Oct 24, 2023

Yes, it seems it didn't start with an underscore before ? We could also just drop support for the old NL syntax from PolyJuMP but I don't want to make a breaking release

SpecialFunctions = "0.8, 1, 2"
Test = "1.6"
Unicode = "1.6"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted these changes for now because of jump-dev/SCS.jl#284

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odow
Copy link
Member Author

odow commented Oct 25, 2023

Okay, I think this is now ready to go

@odow odow merged commit 67085f1 into master Oct 25, 2023
@odow odow deleted the od/1.21 branch October 25, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants