Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bridges] add support for start values in NumberConversionBridge #2338

Merged
merged 5 commits into from
Nov 2, 2023
Merged

[Bridges] add support for start values in NumberConversionBridge #2338

merged 5 commits into from
Nov 2, 2023

Conversation

odow
Copy link
Member

@odow odow commented Nov 2, 2023 •
edited
Loading

Part of #684

This isn't very obvious what the return types should be, so I've opted to just leave them as-is and let the solvers deal with them. I used value_type.

@odow odow requested a review from blegat November 2, 2023 03:08
@blegat
Copy link
Member

blegat commented Nov 2, 2023

Yes, value_type seems to be the way to go

@odow odow merged commit 5f6d812 into master Nov 2, 2023
16 checks passed
@odow odow deleted the od/bridge-number-conversion-start branch November 2, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @blegat