Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConstraintIndex conflicts between variable and constraint bridges #2358

Closed
wants to merge 4 commits into from

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 13, 2023

Fix one of the bugs detected by #2357

  • Add comments/docstrings to explain the new design
  • Add a custom test not not only rely on the tests brought up by Run all tests against bridged SDPA model #2357
  • Add a check in add_bridge and remove_bridge that the negation does not change

@odow
Copy link
Member

odow commented Dec 14, 2023

We probably need to discuss this more. I didn't have a good look at it. Will do tomorrow

@blegat
Copy link
Member Author

blegat commented Dec 14, 2023

Actually this does not work since we may also have the case where constrained variables in S are bridged and VectorOfVariables-in-S are not bridged but we are forced to apply a FunctionizeBridge because one of the variable is a bridged variable. Let me think about it

@blegat
Copy link
Member Author

blegat commented Dec 14, 2023

I have a simpler idea, hold off reviewing

@odow
Copy link
Member

odow commented Dec 19, 2023

Closing in favor of #2362

@odow odow closed this Dec 19, 2023
@odow odow deleted the bl/negate branch December 20, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants