Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing C++ methods #49

Open
odow opened this issue Apr 18, 2023 · 2 comments
Open

Add missing C++ methods #49

odow opened this issue Apr 18, 2023 · 2 comments

Comments

@odow
Copy link
Member

odow commented Apr 18, 2023

The MOI wrapper ignores .silent because setDisplay isn't exposed in the C++ API.

# TODO Take `silent` into account here

@odow
Copy link
Member Author

odow commented Apr 18, 2023

Fixing this requires editing
https://github.com/JuliaPackaging/Yggdrasil/blob/02e89ac8e7f719b46548532c960c52fc85396338/S/SDPA/bundled/sdpawrap/sdpawrap.cpp#L27-L66

Here's a bunch of candidates to add:

  void setParameterPrintXVec(char* xPrint);
  void setParameterPrintXMat(char* XPrint);
  void setParameterPrintYMat(char* YPrint);
  void setParameterPrintInformation(char* infPrint);

  void setDisplay(FILE* Display  = stdout);
  void setResultFile(FILE* fpout = stdout);
  void setInitPoint(bool isInitPoint);

  void setNumThreads(int NumThreads=0);

  ParameterType getParameterType();
  int    getParameterMaxIteration();
  double getParameterEpsilonStar ();
  double getParameterLambdaStar  ();
  double getParameterOmegaStar   ();
  double getParameterLowerBound  ();
  double getParameterUpperBound  ();
  double getParameterBetaStar    ();
  double getParameterBetaBar     ();
  double getParameterGammaStar   ();
  double getParameterEpsilonDash ();

  char* getParameterPrintXVec();
  char* getParameterPrintXMat();
  char* getParameterPrintYMat();
  char* getParameterPrintInformation();

  FILE* getDisplay();
  FILE* getResultFile();
  bool getInitPoint();
  
  int getNumThreads();

@odow odow changed the title SDPA does't use Silent Add missing C++ methods Apr 18, 2023
@blegat
Copy link
Member

blegat commented Apr 18, 2023

Good catch, we were wondering with @egidioln why the silent setting wasn't working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants