Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test image generation #1357

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

dennyscode
Copy link
Contributor

@dennyscode dennyscode commented Oct 1, 2024

Ticket: https://lifi.atlassian.net/browse/LF-10000

Each route.tsx includes some notes with available params + example
As of now, I have created 5 endpoints to generate images: (1) selection of tokens -> (2) quotes -> (3) review -> (4) execution -> (5) success

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jumper-exchange ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:28pm

Copy link

github-actions bot commented Oct 14, 2024

Playwright test results

passed  11 passed
skipped  3 skipped

Details

stats  14 tests across 2 suites
duration  1 minute, 55 seconds
commit  edd0d5b

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to Supefest
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color

@dennyscode
Copy link
Contributor Author

dennyscode commented Oct 14, 2024

@tcheee @oktapodia @admsk2

I need to pick your brain on the following:

1.) caching -> I am already trying but somehow feel like this is not the most we can get out of it (see image)

2.) url -> New images are placed inside public folder and needed during API calls -> How can I reference to it via a URL? (I need the origin of the url / baseUrl).
Good example: Feature-Branches do not have fixed URL´s. What´s best to make it work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants