chore: remove superfest #1368
chore: remove superfest #1368
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test results
Details
Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to Supefest |
src/components/ProfilePage/QuestCardCompleted/QuestCardCompleted.style.ts
Outdated
Show resolved
Hide resolved
| position: 'relative', | ||
| bottom: '16px', | ||
| right: '32px', | ||
| padding: '6px', |
There was a problem hiding this comment.
| padding: '6px', | |
| padding: theme.spacing(0.75), |
There was a problem hiding this comment.
why sometimes using theme.spacing and sometimes just removing "px"?
There was a problem hiding this comment.
Good point, I messed up if I did and in the perfect world, I´d stick with one approach:
We can discuss in the team, if we can agree on a certain approach: For me properties like margin, padding, gap are related to spacings. I try to avoid theme.spacing on any styles like borderRadius, height, width, whatsoever...
| borderRadius: '128px', | ||
| justifyContent: 'center', | ||
| })); | ||
|
|
||
| export interface XPDisplayBoxProps extends Omit<BoxProps, 'component'> { | ||
| active?: boolean; | ||
| } | ||
|
|
||
| export const XPDisplayBox = styled(Box, { | ||
| shouldForwardProp: (prop) => prop !== 'active', | ||
| })<XPDisplayBoxProps>(({ active }) => ({ |
There was a problem hiding this comment.
If those suggestions make use of theme we must make sure, it´s provided. Just flying over it, I have not double-checked on each styled-component if theme is available!!
| height: '416px', | ||
| width: '272px', |
There was a problem hiding this comment.
| height: '416px', | |
| width: '272px', | |
| height: 416, | |
| width: 272, |
| height: '416px', | ||
| width: '256px', | ||
| borderRadius: '8px', | ||
| width: '272px', |
There was a problem hiding this comment.
| width: '272px', | |
| width: 272, |
|
Nice! Much better already but let´s also come back and reduce number of "QuestCards" (currently used in "Quests" and "ProfilePage" folders) or maybe rename such components. The same with QuestCardSkeleton. We already discussed, this is just a note. |
Co-authored-by: dennyscode <[email protected]>
Co-authored-by: dennyscode <[email protected]>
Co-authored-by: dennyscode <[email protected]>
Co-authored-by: dennyscode <[email protected]>
…ed.style.ts Co-authored-by: dennyscode <[email protected]>
…ed.style.ts Co-authored-by: dennyscode <[email protected]>
…ed.style.ts Co-authored-by: dennyscode <[email protected]>
…ed.style.ts Co-authored-by: dennyscode <[email protected]>
Co-authored-by: dennyscode <[email protected]>
A bit different from what we discussed. But yes agree with you, let's clean the naming or remove one of them, good call. |
No description provided.