Use EventCollector if possible. #936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbirkner
changed the title
| */ | ||
| public class EventCollector extends RunListener { | ||
|
|
||
| private final List<Description> fTestRunsStarted = synchronizedList(new ArrayList<Description>()); |
There was a problem hiding this comment.
We no longer use an f prefix for fields
There was a problem hiding this comment.
This code is much older :-)
Done.
|
Very nice. I do think some of the test support code could use some tests. Don't go crazy; "test until fear turns to boredom" :-) |
|
Were you going to add tests for some of the non-trivial code in the |
|
Yes. I already started. |
stefanbirkner
force-pushed
the
listener
branch
3 times, most recently
from
bbdcf28
to
3eb5e8c
Compare
|
@stefanbirkner LGTM! Do you want to take another look before we merge it? |
|
Needs squashing, though. |
stefanbirkner
force-pushed
the
listener
branch
4 times, most recently
from
8e4aeef
to
4036fa6
Compare
Avoids duplicate implementations of RunListener for different test and provides Hamcrest matchers for verifying events sent to the listener.
stefanbirkner
force-pushed
the
listener
branch
from
4036fa6
to
ae86bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids duplicate implementations of RunListener for different test and
provides Hamcrest matchers for verifying events sent to the listener.