Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add junit5-jupiter-starter-maven-kotlin sample #70 #102 #103

Merged
merged 1 commit into from
May 27, 2019
Merged

Add junit5-jupiter-starter-maven-kotlin sample #70 #102 #103

merged 1 commit into from
May 27, 2019

Conversation

daggerok
Copy link
Contributor

@daggerok daggerok commented May 26, 2019

This PR contains junit5-jupiter-starter-maven-kotlin sample.

Given project allows mix java and Kotlin test classes together by using JUnit 5 Jupiter and JUnit 4 Vintage test engines.

That PR was added in scope of existing Create "missing" samples #70 GitHub issue.

Overview

  • contains wrapper (maven version: 3.6.1)
  • supports java 1.8 (see pom-java8.xml file) as well as java 11
  • using latest Jupiter versions at the moment and latest stable Kotlin available in maven central

I hereby agree to the terms of the JUnit Contributor License Agreement.

@sormuras sormuras self-assigned this May 26, 2019
Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring out a solution that works with Maven + Kotlin ... and submitting it as a sample. That's awesome!

  • The junit5-samples focus on Java 8. Please remove the Java 11 based stage from the .travis.yml script. It'd be cool though, if you explain necessary changes (are there any?) for making your setup run on Java 11.
  • The junit5-samples focus using published version of the "JUnit 5" artifacts. Can you please downgrade your setup to use Jupiter 5.4.2?
  • Please remove the not matching source units from the language specific directories. Keep the information what works and what not in the README.md -- a sample should not show "bad" examples, like having .kt files below src/main/java.

@daggerok
Copy link
Contributor Author

daggerok commented May 26, 2019

Hello @sormuras,

I have applied your review comments.
Not sure if I understand correctly your point:

Please remove the not matching source units from the language specific directories. Keep the information what works and what not in the README.md -- a sample should not show "bad" examples, like having .kt files below src/main/java.

There are actually no Kotlin files in src/main/java, it was note that they are going to be executed in case if they will be located there... Anyway, I have cleaned up README.md file

Please let me know if I missed something


Regards

@daggerok
Copy link
Contributor Author

Squashed commits

Allows mix java and kotlin test classes by using JUnit 5 Jupiter and JUnit 4 Vintage test engines together.
This sample was added in scope of Create "missing" samples #70 GitHub issue.
@daggerok
Copy link
Contributor Author

Please review

@sormuras sormuras merged commit 5ef6b67 into junit-team:master May 27, 2019
@sormuras
Copy link
Member

Thanks @daggerok!

@sormuras
Copy link
Member

@daggerok -- do you want to take over #104 and/or #105 as well? ;-)

@daggerok
Copy link
Contributor Author

Hey @sormuras,
Yes, I can take a look on it this weekend

@daggerok daggerok deleted the junit5-jupiter-starter-maven-kotlin branch May 27, 2019 17:03
@sormuras
Copy link
Member

That'd be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants