-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add junit5-jupiter-starter-maven-kotlin sample #70 #102 #103
Add junit5-jupiter-starter-maven-kotlin sample #70 #102 #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for figuring out a solution that works with Maven + Kotlin ... and submitting it as a sample. That's awesome!
- The
junit5-samples
focus on Java 8. Please remove the Java 11 based stage from the.travis.yml
script. It'd be cool though, if you explain necessary changes (are there any?) for making your setup run on Java 11. - The
junit5-samples
focus using published version of the "JUnit 5" artifacts. Can you please downgrade your setup to use Jupiter5.4.2
? - Please remove the not matching source units from the language specific directories. Keep the information what works and what not in the
README.md
-- a sample should not show "bad" examples, like having.kt
files belowsrc/main/java
.
Hello @sormuras, I have applied your review comments.
There are actually no Kotlin files in src/main/java, it was note that they are going to be executed in case if they will be located there... Anyway, I have cleaned up README.md file Please let me know if I missed something Regards |
Squashed commits |
Allows mix java and kotlin test classes by using JUnit 5 Jupiter and JUnit 4 Vintage test engines together. This sample was added in scope of Create "missing" samples #70 GitHub issue.
Please review |
Thanks @daggerok! |
Hey @sormuras, |
That'd be awesome. |
This PR contains junit5-jupiter-starter-maven-kotlin sample.
Given project allows mix java and Kotlin test classes together by using JUnit 5 Jupiter and JUnit 4 Vintage test engines.
That PR was added in scope of existing Create "missing" samples #70 GitHub issue.
Overview
pom-java8.xml
file) as well as java 11I hereby agree to the terms of the JUnit Contributor License Agreement.