Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kotlin contracts to exposed Kotlin API #3259

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
+486 −21
Open

Add Kotlin contracts to exposed Kotlin API #3259

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e3b3ac3
Added contracts for kotlin assertions
awelless Apr 7, 2023
edbe73f
Merge branch 'main' into main
awelless Aug 10, 2023
252cad2
Mark new kotlin assetion methods as experimental
awelless Apr 23, 2023
1d5811b
Adjust assertThrows contract
awelless Jun 3, 2023
19922d6
Add contract for fail
awelless Jun 3, 2023
eccb259
Don't return a value from assertNotNull
awelless Aug 25, 2023
e427978
Increase API version
awelless Aug 25, 2023
544b4e1
Add assertInstanceOf methods
awelless Aug 25, 2023
437d29e
assertInstanceOf methods accept nullable values
awelless Aug 25, 2023
43c08ea
Test for assertInstanceOf nullable upcast
awelless Aug 27, 2023
ff9fd39
Specify lambda InvocationKind explicitly for assertThrows methods
awelless Aug 27, 2023
5a70965
Rename variable names in new assertion examples
awelless Sep 1, 2023
666f73f
Add API annotation for new fail assertion
awelless Sep 1, 2023
9920cf9
Make the comments be sentences
awelless Sep 1, 2023
4d21486
Adjust contract for assertTimeoutPreemptively
awelless Sep 1, 2023
30b9b78
Removed contracts for methods where lambdas may throw exceptions
awelless Sep 8, 2023
41f00c0
Add more tests for methods with contracts
awelless Sep 23, 2023
69e9c38
Merge branch 'main' into main
awelless Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions documentation/src/docs/asciidoc/release-notes/release-notes-5.11.0-M1.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ JUnit repository on GitHub.

==== New Features and Improvements

* ❓

* Introduced kotlin contracts for kotlin assertion methods

[[release-notes-5.11.0-M1-junit-jupiter]]
=== JUnit Jupiter
Expand Down
8 changes: 8 additions & 0 deletions junit-jupiter-api/junit-jupiter-api.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,11 @@ tasks {
}
}
}

kotlin {
sourceSets {
main {
languageSettings.optIn("kotlin.contracts.ExperimentalContracts")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do consumers of junit-jupiter-api also have to opt-in? If so, what happens of they don't?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, since we opt-in in the junit-jupiter-api, consumers don't need to specify any opt-ins in their code

}
}
}
Loading
Loading