Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate custom ptx-builder into rust-cuda-kernel #24

Merged
merged 14 commits into from
Oct 30, 2024
Merged

Conversation

juntyr
Copy link
Owner

@juntyr juntyr commented Oct 26, 2024

The upstream ptx-builder has been unmaintained for years and this crate has instead relied on a custom fork, https://github.com/juntyr/rust-ptx-builder, that was updated for newer Rust versions and contained extra features, e.g. to support live build progress feedback.

While ptx-builder needs to support a variety of use cases, rust-cuda-kernel requires much less. Maintaining the fork took extra effort when the needed functionality could just be upstreamed into rust-cuda-kernel.

This PR iteratively stripped the ptx-builder codebase down to only the needed parts and then refactored them to better integrate with the existing code.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.82334% with 102 lines in your changes missing coverage. Please review.

Project coverage is 33.35%. Comparing base (a915a77) to head (30e9623).

Files with missing lines Patch % Lines
rust-cuda-kernel/src/kernel/link/mod.rs 72.31% 80 Missing ⚠️
src/utils/async.rs 0.00% 7 Missing ⚠️
rust-cuda-kernel/src/kernel/specialise/function.rs 0.00% 5 Missing ⚠️
...st-cuda-kernel/src/kernel/specialise/param_type.rs 0.00% 3 Missing ⚠️
src/safety/ptx_entry_point.rs 0.00% 3 Missing ⚠️
rust-cuda-derive/src/rust_to_cuda/generics.rs 0.00% 2 Missing ⚠️
rust-cuda-kernel/src/kernel/wrapper/mod.rs 66.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   31.88%   33.35%   +1.46%     
==========================================
  Files          54       53       -1     
  Lines        6576     6653      +77     
==========================================
+ Hits         2097     2219     +122     
+ Misses       4479     4434      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juntyr juntyr marked this pull request as ready for review October 30, 2024 05:38
@juntyr juntyr changed the title Start vendoring ptx-builder as rust-cuda-builder Integrate custom ptx-builder into rust-cuda-kernel Oct 30, 2024
@juntyr juntyr merged commit 62e96a9 into main Oct 30, 2024
3 of 6 checks passed
@juntyr juntyr deleted the rust-cuda-builder branch October 30, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants