-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate custom ptx-builder
into rust-cuda-kernel
#24
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 31.88% 33.35% +1.46%
==========================================
Files 54 53 -1
Lines 6576 6653 +77
==========================================
+ Hits 2097 2219 +122
+ Misses 4479 4434 -45 ☔ View full report in Codecov by Sentry. |
ptx-builder
into rust-cuda-kernel
The upstream
ptx-builder
has been unmaintained for years and this crate has instead relied on a custom fork, https://github.com/juntyr/rust-ptx-builder, that was updated for newer Rust versions and contained extra features, e.g. to support live build progress feedback.While
ptx-builder
needs to support a variety of use cases,rust-cuda-kernel
requires much less. Maintaining the fork took extra effort when the needed functionality could just be upstreamed intorust-cuda-kernel
.This PR iteratively stripped the
ptx-builder
codebase down to only the needed parts and then refactored them to better integrate with the existing code.