-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of transactions #44
Open
serejke
wants to merge
94
commits into
jup-ag:main
Choose a base branch
from
serejke:fix-parsing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Event Parser
Fixes for v61
fix type error
Fix event parser
Update tests
Update to latest token list api
Fix extracting swaps for inner jupiter routing instructions
This PR fixes #32 |
Additionally, the parser now throws an error with the unknown instruction name Also added support of the Jupiter Labs Perpetuals program's V2 instruction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes parsing for some corner cases.
The PR updates the Jupiter IDL to the latest version fetched from https://solscan.io/account/JUP6LkbZbjS1jKKwapdHNy74zcZ3tLUZoi5QNyVTaV4#anchorProgramIdl
The new IDL version contains new instructions (like
CreateTokenAccount
), which were not recognized before. This transaction couldn't be parsed because theEventParser
did not recognize the new Jupiter's instruction.Separately, the fee parser now properly recognizes and ignores the
memo
instruction. The memo has a differentparsed
data (for this example transaction):which led to null-pointer error in this line (since the
data.destination
field is not there):instruction-parser/src/lib/event-parser.ts
Line 371 in fc16adf