Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for http adapter config #820

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Added support for http adapter config #820

merged 3 commits into from
Jul 26, 2023

Conversation

venu1412
Copy link
Contributor

@venu1412 venu1412 commented Jun 28, 2023 •
edited
Loading

Description

Checklist

  • Wrote a description of my changes above
  • Formatted my code with black
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • Added or modified unit tests to reflect my changes
  • Manually tested with a notebook
  • If adding a feature, there is an example notebook and/or documentation in the README.md file

@devstein devstein self-requested a review June 28, 2023 19:12
@venu1412
Copy link
Contributor Author

@devstein Can you please review this?

devstein
devstein reviewed Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@venu1412 Great feature, thank you for contributing!

Minor code question/changes for invalid adapter configs. Can you add some documentation for how to use this feature and some use-cases? The best place would either be in a new section in the top-level README or in an example notebook.

sparkmagic/sparkmagic/livyclientlib/reliablehttpclient.py Outdated Show resolved Hide resolved
sparkmagic/sparkmagic/livyclientlib/reliablehttpclient.py Outdated Show resolved Hide resolved
@venu1412
Copy link
Contributor Author

@devstein i have resolved the comments and also added the the documentation on how to use it and when to use it. Can you please take a look again?

devstein
devstein reviewed Jul 26, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
sparkmagic/sparkmagic/livyclientlib/exceptions.py Outdated Show resolved Hide resolved
devstein
devstein approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@venu1412 Nice work! I'll cut a new release soon

@devstein devstein merged commit d5f6e09 into jupyter-incubator:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devstein devstein devstein approved these changes

Assignees

@venu1412 venu1412

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@venu1412 @devstein @vallenki