-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to have default config options for spark #830
Conversation
e9ffe50
to
bc00e35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c2zwdjnlcg Thanks for making a PR! This is a common feature request from users.
I like the implementation -- it's simple, but satisfies the requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much experience with sparkmagic, but things seem ok to me.
If anything maybe a docstring in def _recursive_merge
that warns the both(?) arguments are mutated and that it is recommended to deepcopy them before passing it in – which you do when you use it. But it my not be obvious at first glance.
Adds a session_configs_defaults config option that gets merged with session_configs This way users can use the configure magic to change session configs but any settings set in as defaults are preserved unless explicitly overridden by the user
bc00e35
to
ca7a7c9
Compare
Added a docstring to recommend deepcopy |
@c2zwdjnlcg Thanks for contributing! |
@devstein thanks for merging. When is the next release scheduled for? |
@c2zwdjnlcg I need to fix an outstanding issue with CI failing (help is welcome!). Once that's fix I'll create a new release. I'm busy with other work, so my best guess is 2-3 weeks |
thanks, i opened #831 hopefully that helps |
Adds a session_configs_defaults config option that gets merged with session_configs
This way users can use the configure magic to change session configs but any settings set in as defaults are preserved unless explicitly overridden by the user
Checklist
black
CHANGELOG.md
fileREADME.md
file