Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting issue #836

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix formatting issue #836

merged 1 commit into from
Sep 13, 2023

Conversation

Strunevskiy
Copy link
Contributor

Description

Fix formatting issue

Checklist

  • Wrote a description of my changes above
  • Formatted my code with black
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • Added or modified unit tests to reflect my changes
  • Manually tested with a notebook
  • [N/A] If adding a feature, there is an example notebook and/or documentation in the README.md file

@dosubot dosubot bot added the kind:bug An unexpected error or issue with sparkmagic label Sep 13, 2023
@Strunevskiy
Copy link
Contributor Author

@devstein could you please take a look at this formatting fix, it looks like my previous PR did not have it.
I am sorry for this.

devstein
devstein approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it. Thanks for following up

@devstein devstein merged commit 8ffc0d2 into jupyter-incubator:master Sep 13, 2023
1 check passed
@Strunevskiy
Copy link
Contributor Author

@devstein do you know why we do not run tests as part of merge or PR ?

@devstein
Copy link
Collaborator

@Strunevskiy No 🤔 this PR should fix it #837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devstein devstein devstein approved these changes

Assignees
No one assigned
Labels
kind:bug An unexpected error or issue with sparkmagic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strunevskiy @devstein