Skip to content

Commit

Permalink
[MRG] link server extension subcommands to main app (#157)
Browse files Browse the repository at this point in the history
* link server extension subcommands to main app

* Refactor extension subapp interface and add tests

* remove f-strings for 3.5 🤦

* change ModuleNotFoundError to ImportError for py3.5
  • Loading branch information
Zsailer authored and echarles committed Dec 19, 2019
1 parent b8ea3a6 commit 65617ff
Show file tree
Hide file tree
Showing 14 changed files with 389 additions and 398 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ To run the Python tests, use::

If you want coverage statistics as well, you can run::

py.test --cov notebook -v --pyargs jupyter_server
py.test --cov notebook -v

Building the Documentation
--------------------------
Expand All @@ -82,7 +82,7 @@ containing all the necessary packages (except pandoc), use::

conda env create -f docs/environment.yml
source activate server_docs # Linux and OS X
activate notebook_docs # Windows
activate server_docs # Windows

.. _conda environment:
https://conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#creating-an-environment-from-an-environment-yml-file
Expand Down
2 changes: 0 additions & 2 deletions jupyter_server/extension/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +0,0 @@
from .application import ExtensionApp
from .handler import ExtensionHandler
1 change: 0 additions & 1 deletion jupyter_server/extension/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,6 @@ def load_jupyter_server_extension(cls, serverapp, argv=[], **kwargs):
extension.initialize(serverapp, argv=argv)
return extension


@classmethod
def launch_instance(cls, argv=None, **kwargs):
"""Launch the extension like an application. Initializes+configs a stock server
Expand Down
Loading

0 comments on commit 65617ff

Please sign in to comment.