Changes in xclient_zmq API

jupyter-xeus · Mar 21, 2024 · 0874cae · 0874cae
1 parent 16e7136
commit 0874cae
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/include/xeus-zmq/xclient_zmq.hpp b/include/xeus-zmq/xclient_zmq.hpp
@@ -47,8 +47,11 @@ namespace xeus
         void notify_control_listener(xmessage msg);
         void notify_iopub_listener(xmessage msg);
 
-        void start();
         std::optional<xmessage> pop_iopub_message();
+        void connect();
+        void stop_channels();
+        void start();
+        void wait_for_message();
 
     private:
         std::unique_ptr<xclient_zmq_impl> p_client_impl;

diff --git a/src/xclient_zmq.cpp b/src/xclient_zmq.cpp
@@ -73,14 +73,29 @@ namespace xeus
         p_client_impl->notify_iopub_listener(std::move(msg));
     }
 
+    std::optional<xmessage> xclient_zmq::pop_iopub_message()
+    {
+        return p_client_impl->pop_iopub_message();
+    }
+
+    void xclient_zmq::connect()
+    {
+        p_client_impl->connect();
+    }
+
+    void xclient_zmq::stop_channels()
+    {
+        p_client_impl->stop_channels();
+    }
+
     void xclient_zmq::start()
     {
         p_client_impl->start();
     }
 
-    std::optional<xmessage> xclient_zmq::pop_iopub_message()
+    void xclient_zmq::wait_for_message()
     {
-        return p_client_impl->pop_iopub_message();
+        p_client_impl->wait_for_message();
     }
 
     std::unique_ptr<xclient_zmq> make_xclient_zmq(xcontext& context,