addressed some reviews

src/xclient_zmq_impl.cpp

@@ -20,8 +20,8 @@ namespace xeus
                                     const xeus::xconfiguration& config,
                                     nl::json::error_handler_t eh)
         : p_auth(make_xauthentication(config.m_signature_scheme, config.m_key))
-        , m_shell_client(context, config)
-        , m_control_client(context, config)
+        , m_shell_client(context, config.m_transport, config.m_ip, config.m_shell_port)
+        , m_control_client(context, config.m_transport, config.m_ip, config.m_control_port)
         , m_iopub_client(context, config)
         , p_messenger(context)
         , m_error_handler(eh)

src/xdealer_channel.cpp

@@ -15,18 +15,16 @@ namespace xeus
 {
 
     xdealer_channel::xdealer_channel(zmq::context_t& context,
-                                 const xeus::xconfiguration& config)
+                                    const std::string& transport,
+                                    const std::string& ip,
+                                    const std::string& port)
         : m_socket(context, zmq::socket_type::dealer)
-        , m_end_point("")
     {
-        m_end_point = xeus::get_end_point(config.m_transport, config.m_ip, config.m_shell_port);
-
-        m_socket.connect(m_end_point);
+        m_socket.connect(xeus::get_end_point(transport, ip, port));
     }
 
     xdealer_channel::~xdealer_channel()
     {
-        m_socket.disconnect(m_end_point);
     }
 
     void xdealer_channel::send_message(zmq::multipart_t& message)

src/xdealer_channel.hpp

@@ -24,7 +24,9 @@ namespace xeus
     public:
 
         xdealer_channel(zmq::context_t& context,
-                        const xeus::xconfiguration& config);
+                        const std::string& transport,
+                        const std::string& ip,
+                        const std::string& port);
 
         ~xdealer_channel();
 
@@ -34,9 +36,7 @@ namespace xeus
         zmq::socket_t& get_socket();
 
     private:
-
         zmq::socket_t m_socket;
-        std::string m_end_point;
     };
 }
 

src/xiopub_client.cpp

@@ -20,16 +20,12 @@ namespace xeus
     xiopub_client::xiopub_client(zmq::context_t& context,
                                  const xeus::xconfiguration& config)
         : m_iopub(context, zmq::socket_type::sub)
-        , m_iopub_end_point("")
     {
-        m_iopub_end_point = xeus::get_end_point(config.m_transport, config.m_ip, config.m_iopub_port);
-
-        m_iopub.connect(m_iopub_end_point);
+        m_iopub.connect(xeus::get_end_point(config.m_transport, config.m_ip, config.m_iopub_port));
     }
 
     xiopub_client::~xiopub_client()
     {
-        m_iopub.disconnect(m_iopub_end_point);
     }
 
     std::size_t xiopub_client::iopub_queue_size() const

src/xiopub_client.hpp

@@ -43,7 +43,6 @@ namespace xeus
 
     private:
         zmq::socket_t m_iopub;
-        std::string m_iopub_end_point;
 
         std::queue<xmessage> m_message_queue;
         mutable std::mutex m_queue_mutex;