Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concurrency model with uv loops #36

Closed
wants to merge 44 commits into from
Closed

Add concurrency model with uv loops #36

wants to merge 44 commits into from

Conversation

IsabelParedes
Copy link
Member

No description provided.

@IsabelParedes
Copy link
Member Author

Windows tests were failing because they were using the C++11 standard. #38

@IsabelParedes IsabelParedes changed the title [WIP] Add concurrency model with uv loops Add concurrency model with uv loops Mar 13, 2024
@IsabelParedes IsabelParedes marked this pull request as ready for review March 19, 2024 13:41
JohanMabille
JohanMabille requested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for implementing this! Beyond the comments I feft, I wonder if we should type erase the uvw pointer in the make_xserver_uv_main_shell function, so that we can abstract it and remove the dependency to uvw in xeus-zmq in a future iteration.

include/xeus-zmq/xhook_base.hpp Outdated Show resolved Hide resolved
include/xeus-zmq/xhook_base.hpp Outdated Show resolved Hide resolved
include/xeus-zmq/xhook_base.hpp Outdated Show resolved Hide resolved
include/xeus-zmq/xhook_base.hpp Show resolved Hide resolved
include/xeus-zmq/xserver_zmq.hpp Show resolved Hide resolved
src/xshell_default.cpp Outdated Show resolved Hide resolved
src/xshell_uv.cpp Outdated Show resolved Hide resolved
src/xshell_uv.cpp Outdated Show resolved Hide resolved
src/xshell_uv.hpp Outdated Show resolved Hide resolved
test/xmock_interpreter.cpp Outdated Show resolved Hide resolved
@IsabelParedes IsabelParedes marked this pull request as draft April 15, 2024 12:58
@IsabelParedes
Copy link
Member Author

I wonder if we should type erase the uvw pointer in the make_xserver_uv_main_shell function, so that we can abstract it and remove the dependency to uvw in xeus-zmq in a future iteration.

Good idea. I'll look into this

@IsabelParedes IsabelParedes marked this pull request as ready for review April 17, 2024 08:35
@IsabelParedes IsabelParedes marked this pull request as draft April 18, 2024 10:08
@IsabelParedes
Test polls
9eaf4dd
@IsabelParedes
Polling
635fc65
@IsabelParedes
Fix json error
f6d6637
@IsabelParedes
Debug kernel status
50820b7
@IsabelParedes
Get loop pointer
36316da
@IsabelParedes
Use loop pointer
a6c27f9
@IsabelParedes
Run loop
5f52b7b
@IsabelParedes
Debug loop run
8189cf5
@IsabelParedes
Save poll resources
23ce5ba
@IsabelParedes
Refactor
6110af9
@IsabelParedes
Unoverload uv server maker
978e322
@IsabelParedes
Add hook base
3e7a100 
Fix linking issue
@IsabelParedes
Clean up
f05a547
@IsabelParedes
Add default uvw loop
8635ee7
@IsabelParedes
Clean
d80b25d
@IsabelParedes
Update xhook_base
1e5f240 
This commit privatizes virtual methods, exports the class with a macro,
removes the implementation from the public header, and implements proper
entity semantics.
@IsabelParedes
Implement entity semantics
94e57ad
@IsabelParedes
Fix shell classes
145e645
@IsabelParedes
Fix alignment
627f493
@IsabelParedes
Fix rebase conflict
2b60712
@IsabelParedes
Restore tests
791f6ae
@IsabelParedes
Make shell destructors virtual
3038b6f
@IsabelParedes
Add delegating constructor
a09874a
@IsabelParedes
Fix alignment
170ceb6
@IsabelParedes
Clean up uvw preprocessor directives
6585dc2
@IsabelParedes
Add comment to create uv xserver
0b2021f
@IsabelParedes
Copy link
Member Author

Closing this in favor of https://github.com/jupyter-xeus/xeus-uv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsabelParedes @JohanMabille