Skip to content

Commit

Permalink
Unused *args in KernelManager __init__
Browse files Browse the repository at this point in the history
I think that if it is unused, then it is likely a mistake from the
caller that meant to pass a kwargs.

This seem to have been ignored since 7.0.
  • Loading branch information
Carreau committed Nov 6, 2023
1 parent 79fa122 commit e355cc6
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions jupyter_client/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import sys
import typing as t
import uuid
import warnings
from asyncio.futures import Future
from concurrent.futures import Future as CFuture
from contextlib import contextmanager
Expand Down Expand Up @@ -106,6 +107,15 @@ class KernelManager(ConnectionFileMixin):

def __init__(self, *args: t.Any, **kwargs: t.Any) -> None:
"""Initialize a kernel manager."""
if args:
warnings.warn(
'Passing positional only arguments to '
'`KernelManager.__init__` is deprecated since jupyter_client'
' 8.6, and will become an error on future versions. Positional '
' arguments have been ignored since jupyter_client 7.0',
DeprecationWarning,
stacklevel=2,
)
self._owns_kernel = kwargs.pop("owns_kernel", True)
super().__init__(**kwargs)
self._shutdown_status = _ShutdownStatus.Unset
Expand Down

0 comments on commit e355cc6

Please sign in to comment.