Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter-run: avoid traceback for NoSuchKernel #994

Merged
merged 2 commits into from
Sep 29, 2024

Commits on Sep 22, 2024

  1. jupyter-run: avoid traceback for NoSuchKernel

    NoSuchKernel used to raise during KernelManager instantiation,
    but it is now delayed.
    
    Access kernel_spec to ensure it's raised where it will be caught.
    
    Also removes a redundant warning log immediately before raising,
    which prevents complete handling of NoSuchError and produces unavoidable duplicate logs.
    minrk committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    c37bfc5 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. call wait_for_ready() in runapp

    ensures kernel is ready before running
    
    avoids lost output if iopub isn't connected yet
    
    and shutdown kernel when finished, rather than relying on the kernel shutting itself down
    minrk committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3f8dd20 View commit details
    Browse the repository at this point in the history