Skip to content

Commit

Permalink
test,fix: skip test_save_readonly_as on Python 3.7
Browse files Browse the repository at this point in the history
  • Loading branch information
maartenbreddels committed Apr 25, 2024
1 parent 1b46076 commit aebff38
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion nbclassic/tests/end_to_end/test_save_readonly_as.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
"""Test readonly notebook saved and renamed"""


import sys
import traceback

import pytest

from .utils import EDITOR_PAGE, EndToEndTimeout


Expand All @@ -20,7 +23,8 @@ def set_notebook_name(nb, name):
JS = f'() => Jupyter.notebook.rename("{name}")'
nb.evaluate(JS, page=EDITOR_PAGE)


# on Python 3.7 we get an old playwright which hangs on body.press("Escape")
@pytest.mark.skipif(sys.version_info < (3, 8), reason="requires python3.8 or higher due to playwright")
def test_save_readonly_as(notebook_frontend):
print('[Test] [test_save_readonly_as]')
notebook_frontend.wait_for_kernel_ready()
Expand Down

0 comments on commit aebff38

Please sign in to comment.