Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"transient" set to None explicitly breaks execute #321

Open
callmephilip opened this issue Dec 12, 2024 · 1 comment
Open

"transient" set to None explicitly breaks execute #321

callmephilip opened this issue Dec 12, 2024 · 1 comment

Comments

@callmephilip
Copy link
Contributor

callmephilip commented Dec 12, 2024

I am trying to get to the bottom of this issue with deno kernel and so I managed to track it down to the following:

 display_id = content.get("transient", {}).get("display_id", None)

throws when receiving message with the following content (note explicit None which causes the issue):

{'execution_count': 7, 'data': {'text/plain': '\x1b[32m"2.29.4"\x1b[39m'}, 'metadata': {}, 'transient': None}

Should this be addressed in nbclient or is this an issue with the kernel?

@callmephilip
Copy link
Contributor Author

a simple workaround would be something along these lines:

transient = content.get("transient", {})
display_id = transient.get("display_id", None) if transient else None

callmephilip added a commit to callmephilip/nbclient that referenced this issue Dec 13, 2024
davidbrochart pushed a commit that referenced this issue Dec 19, 2024
* gracefully handle explicit transient=None re #321

* rephrase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant