Gracefully handle explicit transient=None #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidbrochart It's been a while since I've shipped one of these packages and I see the releasing steps have changed quite a bit. I'm happy to merge, however I don't wish to break the flow you've got with this package. |
davidbrochart
requested changes
Dec 18, 2024
nbclient/client.py
Outdated
Comment on lines
1106
to
1107
| transient = content.get("transient", {}) | ||
| display_id = transient.get("display_id", None) if transient else None |
There was a problem hiding this comment.
I can be simply:
Suggested change
| transient = content.get("transient", {}) | |
| display_id = transient.get("display_id", None) if transient else None | |
| transient = content.get("transient") | |
| display_id = transient.get("display_id") if transient else None |
There was a problem hiding this comment.
but of course! 🤦♂️
auto-merge was automatically disabled
December 19, 2024 08:35
Head branch was pushed to by a user without write access
davidbrochart
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Thanks @callmephilip.
I'll address the CI failures in #323.
Released in v0.10.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #321