Move handling of the file browser settings to a separate plugin, enable file browser single click navigation #2168
Annotations
9 errors and 2 notices
Update snapshots:
ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Update snapshots:
ui-tests/test/filebrowser.spec.ts#L1
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: Test ended.
Browser logs:
<launching> /home/runner/.cache/ms-playwright/firefox-1465/firefox/firefox -no-remote -headless -profile /tmp/playwright_firefoxdev_profile-a3K0W4 -juggler-pipe -silent
<launched> pid=9186
[pid=9186][err] *** You are running in headless mode.
[pid=9186][err] JavaScript warning: resource://services-settings/Utils.sys.mjs, line 116: unreachable code after return statement
[pid=9186][out] console.warn: services.settings: Ignoring preference override of remote settings server
[pid=9186][out] console.warn: services.settings: Allow by setting MOZ_REMOTE_SETTINGS_DEVTOOLS=1 in the environment
[pid=9186][out] Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: Unable to open a connection to the X server (t=0.234164) [GFX1-]: glxtest: Unable to open a connection to the X server
[pid=9186][out] console.error: ({})
[pid=9186][out]
[pid=9186][out] Juggler listening to the pipe
[pid=9186][out] console.error: ({})
[pid=9186][out] console.error: SearchEngineSelector: "Received empty search configuration!"
[pid=9186][out] console.error: "Received empty top sites configuration!"
[pid=9186][out] console.error: SearchEngineSelector: "Received empty search configuration!"
[pid=9186][out] console.error: SearchService: "#init: failure initializing search:" ({})
[pid=9186][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=9186][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=9186][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=9186][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=9186][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=9186][out] console.error: "Received empty top sites configuration!"
[pid=9186][out] console.error: WebExtensions:
[pid=9186][out] Message: [Exception... "Failed to get engine data from Remote Settings" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: resource://gre/modules/SearchEngineSelector.sys.mjs :: getEngineConfiguration :: line 76" data: no]
[pid=9186][out] Stack:
[pid=9186][out] getEngineConfiguration@resource://gre/modules/SearchEngineSelector.sys.mjs:76:24
[pid=9186][out]
[pid=9186][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=9186][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({})
[pid=9186][out] console.error: SearchSettings: "_write: Could not write to settings file:" (new Error("cannot write without any engine.", "resource://gre/modules/SearchSettings.sys.mjs", 335))
[pid=9186][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=9186][err] JavaScript error: chrome://juggler/content/Helper.js, line 82: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebProgress.removeProgressListener]
[pid=9186][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=9186][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=9186][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=9186][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({})
[pid=9186][out] console.error: URLBar - Provider.Ur
|
Update snapshots:
ui-tests/test/filebrowser.spec.ts#L55
2) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ───────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
53 | expect(toolbar.getByText('Rename')).toBeHidden();
54 | expect(toolbar.getByText('Open')).toBeHidden();
> 55 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
56 | });
57 |
58 | test('Select files and open', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
|
Test:
ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Test:
ui-tests/test/filebrowser.spec.ts#L1
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: Test ended.
Browser logs:
<launching> /home/runner/.cache/ms-playwright/firefox-1465/firefox/firefox -no-remote -headless -profile /tmp/playwright_firefoxdev_profile-m0cpc4 -juggler-pipe -silent
<launched> pid=5886
[pid=5886][err] *** You are running in headless mode.
[pid=5886][err] JavaScript warning: resource://services-settings/Utils.sys.mjs, line 116: unreachable code after return statement
[pid=5886][out] console.warn: services.settings: Ignoring preference override of remote settings server
[pid=5886][out] console.warn: services.settings: Allow by setting MOZ_REMOTE_SETTINGS_DEVTOOLS=1 in the environment
[pid=5886][out] Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: Unable to open a connection to the X server (t=0.363522) [GFX1-]: glxtest: Unable to open a connection to the X server
[pid=5886][out] console.error: ({})
[pid=5886][out]
[pid=5886][out] Juggler listening to the pipe
[pid=5886][out] console.error: ({})
[pid=5886][out] console.error: SearchEngineSelector: "Received empty search configuration!"
[pid=5886][out] console.error: "Received empty top sites configuration!"
[pid=5886][out] console.error: SearchEngineSelector: "Received empty search configuration!"
[pid=5886][out] console.error: SearchService: "#init: failure initializing search:" ({})
[pid=5886][out] console.error: "Received empty top sites configuration!"
[pid=5886][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=5886][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=5886][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=5886][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=5886][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=5886][out] console.error: WebExtensions:
[pid=5886][out] Message: [Exception... "Failed to get engine data from Remote Settings" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: resource://gre/modules/SearchEngineSelector.sys.mjs :: getEngineConfiguration :: line 76" data: no]
[pid=5886][out] Stack:
[pid=5886][out] getEngineConfiguration@resource://gre/modules/SearchEngineSelector.sys.mjs:76:24
[pid=5886][out]
[pid=5886][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=5886][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({})
[pid=5886][out] console.error: SearchSettings: "_write: Could not write to settings file:" (new Error("cannot write without any engine.", "resource://gre/modules/SearchSettings.sys.mjs", 335))
[pid=5886][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=5886][err] JavaScript error: chrome://juggler/content/Helper.js, line 82: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebProgress.removeProgressListener]
[pid=5886][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=5886][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=5886][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=5886][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({})
[pid=5886][out] console.error: URLBar - Provider.Ur
|
Test:
ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Test:
ui-tests/test/filebrowser.spec.ts#L28
2) [firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ──────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
26 |
27 | expect(toolbar.getByText('Rename')).toBeVisible();
> 28 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
29 | });
30 |
31 | test('Select one file', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:28:41
|
Test:
ui-tests/test/filebrowser.spec.ts#L55
3) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ───────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
53 | expect(toolbar.getByText('Rename')).toBeHidden();
54 | expect(toolbar.getByText('Open')).toBeHidden();
> 55 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
56 | });
57 |
58 | test('Select files and open', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
|
Test
Process completed with exit code 1.
|
Update snapshots
2 flaky
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ────────────
34 passed (2.1m)
|
Test
1 failed
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
2 flaky
[firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ───────────────────
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ────────────
33 passed (2.2m)
|
Loading