Move handling of the file browser settings to a separate plugin, enable file browser single click navigation #2169
Annotations
9 errors and 2 notices
Update snapshots:
ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Open')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Open')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Test:
ui-tests/test/filebrowser.spec.ts#L27
1) [firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ──────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Rename')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Rename')
- locator resolved to <span class="jp-ToolbarButtonComponent-label">Rename</span>
- unexpected value "hidden"
25 | const toolbar = page.getByRole('toolbar');
26 |
> 27 | expect(toolbar.getByText('Rename')).toBeVisible();
| ^
28 | expect(toolbar.getByText('Delete')).toBeVisible();
29 | });
30 |
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:27:41
|
Test:
ui-tests/test/filebrowser.spec.ts#L27
1) [firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ──────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Rename')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Rename')
- locator resolved to <span class="jp-ToolbarButtonComponent-label">Rename</span>
- unexpected value "hidden"
- locator resolved to <span class="jp-ToolbarButtonComponent-label">Rename</span>
- unexpected value "hidden"
- locator resolved to <span class="jp-ToolbarButtonComponent-label">Rename</span>
- unexpected value "hidden"
25 | const toolbar = page.getByRole('toolbar');
26 |
> 27 | expect(toolbar.getByText('Rename')).toBeVisible();
| ^
28 | expect(toolbar.getByText('Delete')).toBeVisible();
29 | });
30 |
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:27:41
|
Test:
ui-tests/test/filebrowser.spec.ts#L39
2) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Test:
ui-tests/test/filebrowser.spec.ts#L1
2) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: Test ended.
Browser logs:
<launching> /home/runner/.cache/ms-playwright/firefox-1465/firefox/firefox -no-remote -headless -profile /tmp/playwright_firefoxdev_profile-KorXMH -juggler-pipe -silent
<launched> pid=6282
[pid=6282][err] *** You are running in headless mode.
[pid=6282][err] JavaScript warning: resource://services-settings/Utils.sys.mjs, line 116: unreachable code after return statement
[pid=6282][out] console.warn: services.settings: Ignoring preference override of remote settings server
[pid=6282][out] console.warn: services.settings: Allow by setting MOZ_REMOTE_SETTINGS_DEVTOOLS=1 in the environment
[pid=6282][out] Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: Unable to open a connection to the X server (t=0.260282) [GFX1-]: glxtest: Unable to open a connection to the X server
[pid=6282][out] console.error: ({})
[pid=6282][out]
[pid=6282][out] Juggler listening to the pipe
[pid=6282][out] console.error: ({})
[pid=6282][out] console.error: SearchEngineSelector: "Received empty search configuration!"
[pid=6282][out] console.error: "Received empty top sites configuration!"
[pid=6282][out] console.error: SearchEngineSelector: "Received empty search configuration!"
[pid=6282][out] console.error: SearchService: "#init: failure initializing search:" ({})
[pid=6282][out] console.error: "Received empty top sites configuration!"
[pid=6282][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=6282][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=6282][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=6282][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 76: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings
[pid=6282][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=6282][out] console.error: WebExtensions:
[pid=6282][out] Message: [Exception... "Failed to get engine data from Remote Settings" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: resource://gre/modules/SearchEngineSelector.sys.mjs :: getEngineConfiguration :: line 76" data: no]
[pid=6282][out] Stack:
[pid=6282][out] getEngineConfiguration@resource://gre/modules/SearchEngineSelector.sys.mjs:76:24
[pid=6282][out]
[pid=6282][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=6282][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({})
[pid=6282][out] console.error: SearchSettings: "_write: Could not write to settings file:" (new Error("cannot write without any engine.", "resource://gre/modules/SearchSettings.sys.mjs", 335))
[pid=6282][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({})
[pid=6282][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=6282][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({})
[pid=6282][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=6282][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({})
[pid=6282][err] JavaScript error: http://localhost:8888/static/notebook/374.bundle.js, line 1: TypeError: this.layout is null
[pid=6282][err] JavaScript error: resource:///modules/SearchModeSwitcher.sys.mjs, line 254: TypeError: engine is null
[pid=6282][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({})
[pid=6282][out]
[pid=6282][out]
|
Test:
ui-tests/test/filebrowser.spec.ts#L39
2) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Download')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Download')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Test:
ui-tests/test/filebrowser.spec.ts#L55
3) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ───────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
53 | expect(toolbar.getByText('Rename')).toBeHidden();
54 | expect(toolbar.getByText('Open')).toBeHidden();
> 55 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
56 | });
57 |
58 | test('Select files and open', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
|
Test:
ui-tests/test/notebook.spec.ts#L1
4) [firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ──────────────────
Error: "apiRequestContext.fetch: Target page, context or browser has been closed
Call log:
- → POST http://localhost:8888/api/sessions?1729759725055
- user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:131.0) Gecko/20100101 Firefox/131.0
- accept: */*
- accept-encoding: gzip, deflate, br, zstd
- host: localhost:8888
- accept-language: en-US
- content-type: text/plain;charset=UTF-8
- content-length: 172
- referer: http://localhost:8888/notebooks/test-notebook-Notebook-Title-should-be-rendered-firefox/example.ipynb
- x-xsrftoken: 2|15bcc474|5d811e4af8854cec311916e823c831bc|1729759721
- origin: http://localhost:8888
- sec-fetch-dest: empty
- sec-fetch-mode: cors
- sec-fetch-site: same-origin
- connection: keep-alive
- cookie: username-localhost-8888=2|1:0|10:1729759721|23:username-localhost-8888|196:eyJ1c2VybmFtZSI6ICIxODZiNDJmZWY1ZTQ0NjRmOWU3ZDMxNmZhMzk4MDcyMyIsICJuYW1lIjogIkFub255bW91cyBBdXRvbm9lIiwgImRpc3BsYXlfbmFtZSI6ICJBbm9ueW1vdXMgQXV0b25vZSIsICJpbml0aWFscyI6ICJBQSIsICJjb2xvciI6IG51bGx9|e1cd4fd3d251fff31069725a41593b5671e00366cf2c1e138cbfc0eb81c1d4ef; _xsrf=2|15bcc474|5d811e4af8854cec311916e823c831bc|1729759721
" while running route callback.
Consider awaiting `await page.unrouteAll({ behavior: 'ignoreErrors' })`
before the end of the test to ignore remaining routes in flight.
at /home/runner/work/notebook/notebook/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:961:49
|
Test
Process completed with exit code 1.
|
Update snapshots
1 flaky
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
35 passed (2.0m)
|
Test
2 failed
[firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ───────────────────
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
2 flaky
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ────────────
[firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ───────────────────
32 passed (2.3m)
|
Loading