Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruff config #7190

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Update ruff config #7190

merged 2 commits into from
Dec 19, 2023

Conversation

blink1073
Copy link
Contributor

Use updated recommendations for Ruff config, and the new ruff docstring-code-format that replaces blacken-docs.

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch blink1073/notebook/update-ruff-config-again

@jtpio
Copy link
Member

jtpio commented Dec 15, 2023

Thanks!

The UI tests failure might be relevant? Unless it is caused by a new release of an underlying package?

actual (extra home icon)

image

expected

image

@blink1073
Copy link
Contributor Author

I addressed that failure, but it looks like there is a pre-existing race condition, because this firefox test failed with the same error as this chromium test did: https://github.com/jupyter/notebook/actions/runs/7198343749/job/19607743050

@jtpio
Copy link
Member

jtpio commented Dec 19, 2023

Thanks!

Is this the same error? Now the issue seems to be related to the trusted indicator not being displayed correctly:

Actual

image

Expected

image

But this is likely not related to this PR, as it also happens in #7191 now.

@blink1073
Copy link
Contributor Author

Ah, okay, seems like a race condition.

jtpio
jtpio approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 0a08ba3 into jupyter:main Dec 19, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@blink1073 blink1073

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @jtpio