Fix rich rendering of panels #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a table with a single column, single header and/or single row that contain the renderables. The border color as well as the icon in title depends on the kind of admonition (maybe we want to limit the kind of admonitions. We cannot render only a header, so when the directive has no content, we render only the body.
Carreau
force-pushed
the
fix-rich-admonitions
branch
from
b3cd6b4 to
d3936c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a table with a single column, single header and/or single row that contain the renderables.
The border color as well as the icon in title depends on the kind of admonition (maybe we want to limit the kind of admonitions.
We cannot render only a header, so when the directive has no content, we render only the body.