Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn into class component and hook kernelspy #382

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Jan 22, 2024

If we want to have the kernelspy handler to control the papyri browser from the outside, we need to turn the functional component into a class one for access the methods instead of having closures.

--

Create component ref and hook into the kernelspy.

This using the IPython extension and using ? on an existing object, it
should pop out the right docstring.

%load_ext papyri

import numpy as np
np.einsum?

This using the IPython extension and using `?` on an existing object, it
should pop out the right docstring.

    %load_ext papyri

    import numpy as np
    np.einsum?
@Carreau Carreau changed the title Turn into class component. Turn into class component and hook kernelspy Jan 22, 2024
@Carreau Carreau merged commit d665532 into jupyter:main Jan 31, 2024
12 checks passed
@Carreau Carreau deleted the f-to-c branch January 31, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant