Enable toggling transform controls

[arjxn-py]

toggle-transform.mov

Icon is a draft
In the direction of #573

[github-actions]

Preview PR at appsharing.space

[github-actions]

Integration tests report: appsharing.space

[trungleduc]

Thanks!

[martinRenou]

Is this right? Shouldn't we just set the transformControls object's visible attribute here instead? Or the enabled property

[arjxn-py]

yes, i tried that but just setting those was preventing transformControls from disabling or enabling right on clicking the toggle button, which is why I also had to trigger this part of code:

JupyterCAD/packages/base/src/3dview/mainview.tsx

Lines 1181 to 1196 in 3340d1d

	this._transformControls.attach(matchingChild as BasicMesh);
	const obj = this._model.sharedModel.getObjectByName(selectedMeshName);
	const positionArray = obj?.parameters?.Placement?.Position;
	if (positionArray && positionArray.length === 3) {
	const positionVector = new THREE.Vector3(
	positionArray[0],
	positionArray[1],
	positionArray[2]
	);
	this._transformControls.position.copy(positionVector);
	}
	this._transformControls.visible = true;
	this._transformControls.enabled = true;

[martinRenou]

Hmm, though calling _updateSelected({}) means unselecting anything that was previously selected.

I'm a bit confused you need this code to be triggered again. This code should already have been triggered upon the latest selection.

[arjxn-py]

This code should already have been triggered upon the latest selection.

i am needed to reselect the object manually after toggling the transform controls from the button

though calling _updateSelected({}) means unselecting anything that was previously selected.

yes this is not ideal and should be done better, happy to start iterating & hear thoughts

[martinRenou]

i am needed to reselect the object manually

Do you know why you need that?

[arjxn-py]

i am needed to reselect the object manually

Do you know why you need that?

It was most probably needed because of missing attach & detach calls.
Is it better after f0b2c6d? if not what should be the right method to get the selected object?

[martinRenou]

That does not look correct to me this._pick() will run the raycast picking, so it's entirely dependent on your current mouse position. This means your code does not work (won't attach to the correct object) if the mouse is mal-positioned.

I'm still not sure why you need to attach/detach here?

It should already have been attached here on the latest selection. So AFAIU your code here should only do enabled = false/true and visible = false/true.

[martinRenou]

Just have a comment/question

[trungleduc]

Could you append a div containing the helper text to switch between rotation and translation mode into the main view div element? You could use the absolute position to place it in the bottom right of the viewport. Like this one

[arjxn-py]

Could you append a div containing the helper text to switch between rotation and translation mode into the main view div element? You could use the absolute position to place it in the bottom right of the viewport. Like this one

Yes, that looks great. Thank You 🚀 i'll be on it

[trungleduc]

This element can also be used for the clipping plane