-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox testing in CI #6
Conversation
from urllib import parse | ||
|
||
|
||
@pytest.fixture(scope="function") # module? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it stateful? I'd probably do scope="session"
return {"SSH_KEY_PATH": str(private_key_path), "SSH_KEY_ID": "test_key"} | ||
|
||
|
||
@pytest.fixture(scope="function") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function is the dedfault scope, you can use:
@pytest.fixture(scope="function") | |
@pytest.fixture |
for most fixtures
assert response.status_code == 200 | ||
assert response.url.startswith(ext_url + smart_path) | ||
|
||
# TODO: Should I test token existence? And how? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing token existence will be easier when the tokens are put somewhere.
We still need to make tokens available to notebooks, and storing them in server settings doesn't quite do that. Once we figure out how notebooks should retrieve tokens, this will be testable.
Thanks! |
Set up unit testing and integration testing with CI.
Backend changes
Testing setup
Notes