Upload screenshot as artifact

jupyterhub · Jul 5, 2024 · 3952c14 · 3952c14
1 parent 12eb171
commit 3952c14
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -101,3 +101,11 @@ jobs:
               echo "One or more tests failed!"
               exit 1
           fi
+
+      - name: Upload screenshot
+        uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: screenshots-${{ matrix.vncserver }}
+          path: screenshots/*
+          if-no-files-found: error
diff --git a/tests/test_browser.py b/tests/test_browser.py
@@ -51,8 +51,8 @@ def test_desktop(browser):
     # Screenshot the desktop element only
     # May take a few seconds to load
     page1.wait_for_timeout(5000)
-    # Use a nontemp folder so we can check it manually if necessary
-    screenshot = "screenshots/desktop.png"
+    # Use a non temporary folder so we can check it manually if necessary
+    screenshot = Path("screenshots") / "desktop.png"
     page1.locator("canvas").screenshot(path=screenshot)
 
     # Open clipboard, enter random text, close clipboard