Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize desktop to window, instead of scaling #124

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

manics
Copy link
Member

@manics manics commented Jul 15, 2024

Benefits:

  • The whole window is used instead of just the central portion, making more efficient use of space
  • The desktop is not scaled, so you don't end up with a high resolution desktop that's scaled down to fit the browser window

Example using a smallish browser window:
Before:
image

After:
image

@manics manics added the enhancement New feature or request label Jul 15, 2024
Copy link

Binder 👈 Launch a binder notebook on this branch for commit c9795ea

I will automatically update this comment whenever this PR is modified

@yuvipanda
Copy link
Contributor

This is a clear improvement! Eventually it would be useful to turn this into a dropdown option I think.

thanks @manics

@yuvipanda yuvipanda merged commit 30e67eb into jupyterhub:main Jul 19, 2024
7 checks passed
@manics manics deleted the resizesession branch July 19, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants