document and refactor the handlers #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
reviewed
Nov 2, 2021
|
I relabelled this as documentation/maintenace rather than documentation/enhancement -- which i consisder would be a feature that matters to the end user. |
Co-authored-by: Erik Sundell <[email protected]>
This was referenced Nov 2, 2021
|
I have resolved everything sans the slug debate. There, I have included some code comments as well, see if this is sufficient in your opinion. |
consideRatio
reviewed
Nov 2, 2021
|
Beautiful @lambdaTotoro! I think this is crucial work for someone like me who aren't that familiar with the code base or that haven't tried all the features, such as email-authorization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a thorough pass on the handlers and did some documenting and refactoring in a few places (for example, we now no longer have "AuthorizeHandler", "AuthorizationHandler", and "ChangeAuthorizationHandler" that all do vastly different things).
Also simplified the logic on error reporting in a few places.
Ideally, I would hope that this closes #177.