Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reply gracefully when chat model is not selected #1183

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Reply gracefully when chat model is not selected #1183

merged 3 commits into from
Dec 31, 2024

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Dec 30, 2024

Description

Demo

Screen.Recording.2024-12-30.at.3.46.37.PM.mov

@dlqqq dlqqq added the bug Something isn't working label Dec 30, 2024
srdas
srdas reviewed Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@srdas srdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good! However, I am unable to test this as I keep running into Issue #1172 which blocks opening a chat panel to try this out.

srdas
srdas approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@srdas srdas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that the error of a missing model is provided in chat.
Tested the new code as well and it is working as expected when a model is selected.
image

@dlqqq dlqqq merged commit f44e62b into jupyterlab:main Dec 31, 2024
10 checks passed
@dlqqq dlqqq deleted the fix-1176 branch December 31, 2024 20:50
ellisonbg
ellisonbg reviewed Dec 31, 2024
View reviewed changes
Copy link
Contributor

@ellisonbg ellisonbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor question inline.

packages/jupyter-ai/jupyter_ai/chat_handlers/base.py Show resolved Hide resolved
srdas pushed a commit to srdas/jupyter-ai that referenced this pull request Jan 6, 2025
@dlqqq @srdas
Reply gracefully when chat model is not selected (jupyterlab#1183)
304e0a9 
* add *.chat files to gitignore

* gracefully handle new messages without a selected chat model

* pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellisonbg ellisonbg ellisonbg left review comments

@srdas srdas srdas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with unsupported_slash_commands
3 participants
@dlqqq @ellisonbg @srdas