-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the pip group with 7 updates #16270
Conversation
Updates the requirements on [sphinx](https://github.com/sphinx-doc/sphinx), [matplotlib](https://github.com/matplotlib/matplotlib), [pandas](https://github.com/pandas-dev/pandas), [scipy](https://github.com/scipy/scipy), [ruff](https://github.com/astral-sh/ruff), [pyyaml-include](https://github.com/tanbro/pyyaml-include) and [pydantic](https://github.com/pydantic/pydantic) to permit the latest version. Updates `sphinx` to 7.3.7 - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES.rst) - [Commits](sphinx-doc/sphinx@v1.8.0...v7.3.7) Updates `matplotlib` from 3.8.3 to 3.8.4 - [Release notes](https://github.com/matplotlib/matplotlib/releases) - [Commits](matplotlib/matplotlib@v3.8.3...v3.8.4) Updates `pandas` from 2.2.1 to 2.2.2 - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Commits](pandas-dev/pandas@v2.2.1...v2.2.2) Updates `scipy` from 1.12.0 to 1.13.0 - [Release notes](https://github.com/scipy/scipy/releases) - [Commits](scipy/scipy@v1.12.0...v1.13.0) Updates `ruff` from 0.3.5 to 0.4.2 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@v0.3.5...v0.4.2) Updates `pyyaml-include` to 2.0.2.post1 - [Changelog](https://github.com/tanbro/pyyaml-include/blob/main/CHANGELOG.md) - [Commits](tanbro/pyyaml-include@0.1a1...v2.0.2.post1) Updates `pydantic` to 2.7.1 - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v0.0.2...v2.7.1) --- updated-dependencies: - dependency-name: sphinx dependency-type: direct:production dependency-group: pip - dependency-name: matplotlib dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pip - dependency-name: pandas dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pip - dependency-name: scipy dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pip - dependency-name: ruff dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pip - dependency-name: pyyaml-include dependency-type: direct:production dependency-group: pip - dependency-name: pydantic dependency-type: direct:production dependency-group: pip ... Signed-off-by: dependabot[bot] <[email protected]>
Thanks for making a pull request to jupyterlab! |
I added the needs review tag as this PR will benefit from another look for the string format changes. |
@@ -102,7 +102,7 @@ def develop_labextension( # noqa | |||
full_dest = normpath(pjoin(labext, destination)) | |||
if overwrite and os.path.lexists(full_dest): | |||
if logger: | |||
logger.info("Removing: %s" % full_dest) | |||
logger.info(f"Removing: {full_dest}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, there was some discussion about using f-strings with the Python logger in the Voila repo, with could lead to potential performance issues: voila-dashboards/voila#419 (comment)
Some more info here: https://realpython.com/python-f-strings/#lazy-evaluation-in-logging
Maybe there is a way to configure ruff to not format the strings used with the logger, if we want to follow the recommendation of not interpolating the f-strings when it's not necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtpio You mean logger.info("Removing: %s", full_dest)
vs logger.info(f"Removing: {full_dest}")
, isn't?
If this is the case the two forms are not flagged by Ruff. Here it is flagged because "Removing %s" % full_dest
actually does not use lazy evaluation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, just noticed we were using "Removing: %s" % full_dest
and not "Removing: %s", full_dest
inside the parentheses. Which is indeed probably why Ruff formatted it.
I guess we can then leave that for another PR (deciding which approach to use for the logging module).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtpio just checking we can move forward and leave the log concern as follow-up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, thanks for the reminder 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add this to .git-blame-ignore-revs?
Updates the requirements on sphinx, matplotlib, pandas, scipy, ruff, pyyaml-include and pydantic to permit the latest version.
Updates
sphinx
to 7.3.7Release notes
Sourced from sphinx's releases.
Changelog
Sourced from sphinx's changelog.
... (truncated)
Commits
de4ac2f
Bump to 7.3.7 final4a0c9dd
Return the default value for unsupported theme configuration sections62c3bad
Re-exportpy_sig_re
from the Python domain3bcc669
Defer loading entry-point themes until neededfa4563f
Bump version630b4fb
Bump to 7.3.6 final740b964
fixup! Elaborate a little more in the warning message forconfig.cache
141f3ec
Elaborate a little more in the warning message forconfig.cache
af27188
Addconfig.cache
to the list of warning typesbe2b083
Re-export more names insphinx.domains.python
(#12297)Updates
matplotlib
from 3.8.3 to 3.8.4Release notes
Sourced from matplotlib's releases.
Commits
8fb842c
REL: v3.8.4149521e
Release prep v3.8.439e91a4
Merge branch 'v3.8.3-doc' into v3.8.xe5dd407
Github stats for v3.8.4dbb4e04
Merge pull request #28015 from meeseeksmachine/auto-backport-of-pr-27955-on-v...e0a38c6
Merge pull request #27993 from ksunden/np_2_builddea6de9
Backport PR #27955: Add a draw during show for macos backend0ec1774
Unpin numpy 2 for install, build against numpy rc for isolated builds8f1698f
Merge pull request #28001 from meeseeksmachine/auto-backport-of-pr-28000-on-v...79ee5af
Backport PR #28000: Fix color sequence data for Set2 and Set3Updates
pandas
from 2.2.1 to 2.2.2Release notes
Sourced from pandas's releases.
Commits
d9cdd2e
RLS: 2.2.298aeac9
Backport PR #58209: CI: Pin blosc to fix pytables (#58211)5466f15
Backport PR #58202: DOC/TST: Document numpy 2.0 support and add tests… (#58208)45b0b32
Backport PR #58203 on branch 2.2.x (DOC: Add release date/contributors for 2....c7ec566
Backport PR #58087 on branch 2.2.x (BLD: Build wheels using numpy 2.0rc1) (#5...691fc88
Backport PR #58181 on branch 2.2.x (CI: correct error msg in test_view_index)...a947587
Backport PR #58138 on branch 2.2.x (BLD: Fix nightlies not building) (#58140)b56842d
Backport PR #58100 on branch 2.2.x (MNT: fix compatibility with beautifulsoup...0f83d50
Revert "BLD: Pin numpy on 2.2.x" (#58093)e9b81ee
Backport PR #58126: BLD: Build wheels with numpy 2.0rc1 (#58127)Updates
scipy
from 1.12.0 to 1.13.0Release notes
Sourced from scipy's releases.
... (truncated)
Commits
7dcd8c5
REL: 1.13.0 release commit [wheel build]15a69da
Merge pull request #20375 from tylerjereddy/treddy_prep_1_13_0_final4cbb9e8
DOC: PR 20375 revisions2431661
MAINT: PR 20375 revisions [wheel build]b85940a
DOC, REL: set 1.13.0 final unreleased13c30bd
MAINT: spatial: simplify meson.buildabb04b2
MAINT: spatial: use cython_lapack in spatial/_qhull.pyx729ff0f
BUG: interpolate: Fix wrong warning message if degree=-1 in `interpolate.RBFI...8d82b0a
MAINT, BUG: bump OpenBLAS (#20362)0e67a72
MAINT: backport amos license updateUpdates
ruff
from 0.3.5 to 0.4.2Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
77c93fd
Bump version to 0.4.2 (#11151)1c9f5e3
Display the AST even with syntax errors (#11147)263a0d2
Usemacos-12
to build release wheels (#11146)4738e19
Remove unused lexical error types (#11145)f428bd5
Docs: mentionlint.typing-modules
inTCH001
,TCH002
,TCH003
(#11144)4690890
ruff server
: In 'publish diagnostics' mode, document diagnostics are cleare...19baabb
README: add Apache Superset to project list (#11136)cee38f3
[flake8-blind-expect
] Allow raise from inBLE001
(#11131)e3fde28
[flake8-pyi
] Allow overloaded__exit__
and__aexit__
definitions (`PYI0...1c8849f
Use Matchit to Resolve Per-File Settings (#11111)Updates
pyyaml-include
to 2.0.2.post1Changelog
Sourced from pyyaml-include's changelog.
... (truncated)
Commits
35dcc98
Merge branch 'release/2.0.2.post1'4666926
typo: fix a typo in project classifiers85ac176
Merge tag 'v2.0.2' into develop1c4d491
Merge branch 'release/2.0.2'972580c
bump version 2.0.28a082bb
debug: type annotationsa160b43
optimize: some type hints and annotationa75a092
ci: update pre-commit and ruff077b26e
update pre-commit569ee0d
modify: more typeshedUpdates
pydantic
to 2.7.1Release notes
Sourced from pydantic's releases.
Changelog
Sourced from pydantic's changelog.
... (truncated)
Commits
2612947
2.7.1 release prep (#9307)2b8efa2
Move TODO regarding pickling to markdown (#9288)73d1049
adds test case for unexpected discriminated union behavior (#9236)c33b925
Change CI to usemacos-13
for Python 3.8 and 3.9 (#9305)82e4664
Fix model json schema with config types (#9287)a0f18e3
Fix bullets in Strict Mode docs (#9296)77b0e1c
Address case where model_construct on a class which defines model_post_init f...6322b24
Fixstrict
application tofunction-after
withuse_enum_values
(#9279)bb857bd
docs(performance): remove section on literal vs enum performance (#9262)3c15a8b
docs: makeTypeAdapter
example PEP-8 compliant (#9268)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions