Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More faithful replication of lyft/ratelimit config loading rules: part 1 #46

Merged
merged 5 commits into from
Oct 4, 2019
Merged

More faithful replication of lyft/ratelimit config loading rules: part 1 #46

merged 5 commits into from
Oct 4, 2019

Conversation

neongreen
Copy link
Contributor

@neongreen neongreen commented Oct 4, 2019 •
edited
Loading

  • Rules are loaded recursively.
  • Rules are loaded from files without the .yml extension.

Related to #26.

@neongreen neongreen requested a review from mdimjasevic October 4, 2019 15:16
@neongreen
Copy link
Contributor Author

This PR can be reviewed commit-by-commit.

@neongreen neongreen force-pushed the artyom/load-rules-better branch from 2c3761a to 91dff99 Compare October 4, 2019 15:27
mdimjasevic
mdimjasevic approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that a file type shouldn't be judged by its name extension.

@neongreen neongreen merged commit 96c9ec5 into master Oct 4, 2019
@neongreen neongreen deleted the artyom/load-rules-better branch October 4, 2019 21:00
@neongreen neongreen mentioned this pull request Oct 4, 2019
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neongreen @mdimjasevic