refactor: log event name change #550
Conversation
Sanskar2001
requested review from
seekshiva,
PritishBudhiraja,
ArushKapoorJuspay,
vsrivatsa-edinburgh and
swamu
as code owners
Sanskar2001
added
the
DO NOT MERGE
Sanskar2001
force-pushed
the
log-event-rename
branch
from
fd760d2
to
5ed201c
Compare
Sanskar2001
force-pushed
the
log-event-rename
branch
from
5ed201c
to
be98292
Compare
Sanskar2001
removed
the
DO NOT MERGE
| @@ -39,7 +39,7 @@ type eventName = | |||
| | APP_REINITIATED | |||
| | LOG_INITIATED | |||
| | LOADER_CALLED | |||
| | ORCA_ELEMENTS_CALLED | |||
| | WEB_SDK_IFRAME_MOUNTED | |||
There was a problem hiding this comment.
Could you please explain the use case of this event? Can it be something like HYPER_ELEMENTS_CALLED or ELEMENTS_CALLED?
There was a problem hiding this comment.
We wanted to make it more readable to merchant in control center's audit trail. The names like HYPER_ELEMENTS_CALLED or ELEMENTS_CALLED makes more sense to Hyperswitch devs, but we wanted to make it more generic.
There was a problem hiding this comment.
Could you please rename this to PAYMENT_ELEMENTS_INITIATED. Since we should not have WEB as a prefix for any log event. Also since this is not the only iframe which gets mounted, it will be confusing moving forward
There was a problem hiding this comment.
The name of mobile counter part of this event name is APP_RENDERED so we can use WEB as prefix for this one. Agree, PAYMENT_ELEMENTS_INITIATED is more a generic and umbrella term as it's not only about an iframe. But to a merchant iframe mounted is a more tangible event instead of something like elements initiated. The merchant should be able to derive some sense out of an event name. Let's decide a self explanatory event name for this before moving forward. cc @seekshiva @akash-c-k @PritishBudhiraja
Type of Change
Description
Renamed ORCA_ELEMENTS_CALLED to WEB_SDK_IFRAME_MOUNTED
How did you test it?
Checklist
npm run re:build