Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate local strings to S3 #866

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: migrate local strings to S3 #866

wants to merge 2 commits into from

Conversation

aritro2002
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Migrate local strings to S3

How did you test it?

I tested in local demo store.

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@aritro2002 aritro2002 added Ready for Review PR with label Ready for Review should only be reviewed. DO NOT MERGE Use this label if you want your PR to restrict from merging labels Jan 16, 2025
@aritro2002 aritro2002 self-assigned this Jan 16, 2025
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 16, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  package-lock.json Unsupported file format
  package.json  0% smaller
  src/CardTheme.res Unsupported file format
  src/CardUtils.res Unsupported file format
  src/Components/BillingNamePaymentInput.res Unsupported file format
  src/Components/FullNamePaymentInput.res Unsupported file format
  src/Components/SaveDetailsCheckbox.res Unsupported file format
  src/Components/SurchargeUtils.res Unsupported file format
  src/Components/Terms.res Unsupported file format
  src/FormViewJourney.res Unsupported file format
  src/FormViewTabs.res Unsupported file format
  src/LoaderController.res Unsupported file format
  src/LocaleStrings/LocaleStringHelper.res Unsupported file format
  src/LocaleStrings/LocaleStringTypes.res Unsupported file format
  src/PaymentMethodCollectElement.res Unsupported file format
  src/Payments/CardPayment.res Unsupported file format
  src/Utilities/GZipUtils.res Unsupported file format
  src/Utilities/PaymentMethodCollectUtils.res Unsupported file format
  src/Utilities/Utils.res Unsupported file format
  src/hyper-log-catcher/HyperLogger.res Unsupported file format

@aritro2002 aritro2002 linked an issue Jan 16, 2025 that may be closed by this pull request
Consume Locale from S3 #868
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanskar2001 Sanskar2001 Awaiting requested review from Sanskar2001 Sanskar2001 is a code owner

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

@PritishBudhiraja PritishBudhiraja Awaiting requested review from PritishBudhiraja PritishBudhiraja is a code owner

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

@sakksham7 sakksham7 Awaiting requested review from sakksham7 sakksham7 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@aritro2002 aritro2002

Labels
DO NOT MERGE Use this label if you want your PR to restrict from merging Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consume Locale from S3
1 participant
@aritro2002