-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(connector): [Bamboraapac] shift to hyperswitch_connector crate #5798
Open
Sakilmostak
wants to merge
12
commits into
main
Choose a base branch
from
shift_bamboraapac
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakilmostak
added
A-connector-integration
Area: Connector integration
C-refactor
Category: Refactor
labels
Sep 4, 2024
deepanshu-iiitu
requested changes
Sep 9, 2024
crates/hyperswitch_connectors/src/connectors/bamboraapac/transformers.rs
Outdated
Show resolved
Hide resolved
deepanshu-iiitu
requested changes
Sep 10, 2024
deepanshu-iiitu
previously approved these changes
Sep 10, 2024
deepanshu-iiitu
previously approved these changes
Sep 11, 2024
sai-harsha-vardhan
previously approved these changes
Sep 11, 2024
Sakilmostak
dismissed stale reviews from sai-harsha-vardhan and deepanshu-iiitu
via
October 14, 2024 06:28
052b1c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Shift the connnector integration of bambora apac to hyperswitch_connectors crate
Additional Changes
Motivation and Context
How did you test it?
Tested through Postman:
Note: Need testing for each flow present in bambora apac since the whole integration is shifted
Checklist
cargo +nightly fmt --all
cargo clippy