-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(payments): add time range in list payment attempts query #5959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvdixit88
added
C-bug
Category: Bug
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-payments
Area: payments
A-Analytics
labels
Sep 19, 2024
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Sep 19, 2024
apoorvdixit88
changed the title
fix(payments): add time range in attempt query list
fix(payments): add time range in payment attempt query list
Sep 19, 2024
apoorvdixit88
changed the title
fix(payments): add time range in payment attempt query list
fix(payments): add time range in list payment attempts query
Sep 19, 2024
tsdk02
previously approved these changes
Sep 19, 2024
dracarys18
previously approved these changes
Sep 19, 2024
Chethan-rao
previously approved these changes
Sep 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 19, 2024
apoorvdixit88
dismissed stale reviews from dracarys18 and tsdk02
via
September 19, 2024 14:06
2e27e33
dracarys18
approved these changes
Sep 19, 2024
Chethan-rao
approved these changes
Sep 19, 2024
tsdk02
approved these changes
Sep 19, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Analytics
A-payments
Area: payments
C-bug
Category: Bug
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
TimeRange
type to common utils so that it can be used in diesel models and across all the other api modelsAdditional Changes
Motivation and Context
Closes #5958
How did you test it?
The expected behaviour is same, the query that is getting printed, is now also considering time range.
Request
Response:
Checklist
cargo +nightly fmt --all
cargo clippy