-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): add accept-language from request headers into browser-info #7074
Open
sai-harsha-vardhan
wants to merge
6
commits into
main
Choose a base branch
from
add-accept-language-in-browser-info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
labels
Jan 20, 2025
Changed Files
|
srujanchikke
previously approved these changes
Jan 20, 2025
Narayanbhat166
previously approved these changes
Jan 21, 2025
@@ -1022,6 +1022,7 @@ impl Default for BrowserInfoType { | |||
device_model: Some("Apple IPHONE 7".to_string()), | |||
os_type: Some("IOS or ANDROID".to_string()), | |||
os_version: Some("IOS 14.5".to_string()), | |||
accept_language: None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@@ -52,6 +52,7 @@ fn get_default_browser_info() -> BrowserInformation { | |||
os_type: None, | |||
os_version: None, | |||
device_model: None, | |||
accept_language: None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Since we are considering "en" as the default language. You can add the same here.
sai-harsha-vardhan
dismissed stale reviews from Narayanbhat166 and srujanchikke
via
January 21, 2025 07:04
0582ec6
srujanchikke
previously approved these changes
Jan 21, 2025
ShankarSinghC
previously approved these changes
Jan 21, 2025
sai-harsha-vardhan
dismissed stale reviews from ShankarSinghC and srujanchikke
via
January 22, 2025 18:24
b5dae84
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Tested Manually
Perform a sanity external authentication payment through Netcetera
CURL
Raw connector Request
Browser Info in Database
Checklist
cargo +nightly fmt --all
cargo clippy