Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nix-direnv.package in home-manager override Nix #68

Open
srid opened this issue Aug 26, 2024 · 3 comments
Open

Make nix-direnv.package in home-manager override Nix #68

srid opened this issue Aug 26, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@srid
Copy link
Collaborator

srid commented Aug 26, 2024

Current

https://github.com/nix-community/home-manager/blob/c2cd2a52e02f1dfa1c88f95abeb89298d46023be/modules/programs/direnv.nix#L95

Expected

Override nix package like nixos module does:

https://github.com/NixOS/nixpkgs/blob/6a9d18e057c1dbd6acefa6fe094de8f3c68051a2/nixos/modules/programs/direnv.nix#L64

Context

The reverted PR: #66

@srid srid added the good first issue Good for newcomers label Aug 26, 2024
@srid
Copy link
Collaborator Author

srid commented Aug 26, 2024

Until then,

image

@shivaraj-bh
Copy link
Member

nix-community/home-manager#5773 resolves this issue

srid added a commit that referenced this issue Aug 28, 2024
@srid
Copy link
Collaborator Author

srid commented Sep 13, 2024

@shivaraj-bh Can we get that PR merged by asking someone upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants