direnv: Use the same nix package #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srid
added a commit
to srid/nixos-config
that referenced
this pull request
Aug 26, 2024
shivaraj-bh
reviewed
Aug 26, 2024
| @@ -121,6 +121,7 @@ | |||
| # https://nixos.asia/en/direnv | |||
| direnv = { | |||
| enable = true; | |||
| package = config.nix.package; | |||
There was a problem hiding this comment.
Isn't it nix-direnv.package instead of direnv.package
There was a problem hiding this comment.
Ah, yes, this PR broke stuff.
But your change is also not correct?
There was a problem hiding this comment.
It is already using config.nix.package. I'll revert this PR for now.
There was a problem hiding this comment.
Actually, this was my fault for not paying attention to Rana's actual change:
There was a problem hiding this comment.
@srid the nix-direnv configuration above is from nixos modules and not from home-manager.
This has to be fixed in home-manager to match nixos module.
There was a problem hiding this comment.
Let's upstream that to hm: #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In direnv, use the same Nix package as the user specifies here:
nix-dev-home/home/default.nix
Lines 9 to 12 in d9df14e
context: