Use --quiet --quiet by default for om ci and om show
#324
Conversation
no allow_hyphens
|
I just realised, Edit: It will be useful during omnix/crates/nixci/src/step/flake_check.rs Lines 37 to 39 in be6ce4a |
|
In [what] situations do we need this done for |
When omnix/crates/nix_rs/src/flake/schema.rs Line 84 in be6ce4a |
|
On a second thought, it would be more appropriate to localise modifying |
Not sure I understand. I don't see any override input relate logs when running, for example, |
|
The logs from |
| @@ -119,6 +124,13 @@ impl NixCmd { | |||
| cmd | |||
| } | |||
|
|
|||
| /// Suppress logs related to `override-input` usage by reducing `nix` command's verbosity | |||
There was a problem hiding this comment.
Is this (Suppress logs related to override-input usage) the only effect of using --quiet --quiet or does it suppress anything else?
There was a problem hiding this comment.
If it does more than that, then function (mute_override_input_logs) wouldn't be accurate.
There was a problem hiding this comment.
Logically, it reduces verbosity level of the logs. I could rename the function to depict that.
There was a problem hiding this comment.
@shivaraj-bh I tried out this PR locally and there appears to be a bug.
Basically it suppresses the entire output of nix build (I see no build logs):
Compare this branch:
vs main:
| @@ -40,6 +40,10 @@ pub struct NixCmd { | |||
| #[cfg_attr(feature = "clap", arg(long))] | |||
| pub extra_access_tokens: Vec<String>, | |||
|
|
|||
| /// Arguments to pass verbatim to the Nix command | |||
| #[cfg_attr(feature = "clap", arg(last = true))] | |||
| pub extra_args: Vec<String>, | |||
There was a problem hiding this comment.
Instead of extra_args, just add a quiet field looking like this. It is more self-documenting.
|
Okay it doesn't suppress the entire output, but it certainly suppresses some of it, leaving just:
|
|
Closing per #300 (comment) |
resolves #300