Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed intel build #111

Closed
wants to merge 1 commit into from
Closed

fixed intel build #111

wants to merge 1 commit into from

Conversation

1vipulgupta
Copy link
Collaborator

No description provided.

srid
srid requested changes Dec 19, 2023
View reviewed changes
flake.nix Outdated
Comment on lines 80 to 84
]) ++ lib.optionals pkgs.stdenv.isDarwin (
[ pkgs.darwin.apple_sdk_11_0.frameworks.IOKit
pkgs.darwin.apple_sdk_11_0.frameworks.Security
]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in rust.nix (rustBuildInputs). Also, CI fails due to not having run autoformatter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding in rustBuildInputs is causing nix run failing. Updated and added to devShells.rust

Copy link
Member

@srid srid Dec 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

causing nix run failing

Please post the full error.

devShells.rust already uses rustBuildInputs transitively, so the devShell will now have duplicate IOKit and Security frameworks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error occurred: Command env -u IPHONEOS_DEPLOYMENT_TARGET "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=x86_64-apple-darwin" "-Wall" "-Wextra" "-o" "/private/tmp/nix-build-nix-browser-deps-0.1.0.drv-0/source/target/release/build/tao-fde661b9405e71cb/out/src/platform_impl/macos/carbon_hotkey/carbon_hotkey_binding.o" "-c" "src/platform_impl/macos/carbon_hotkey/carbon_hotkey_binding.c" with args "clang" did not execute successfully (status code exit status: 1).

@srid
Copy link
Member

srid commented Mar 22, 2024

main branch builds on Intel mac (https://github.com/juspay/nix-browser/blob/main/.github/workflows/ci.yaml) and I've confirmed that the app runs locally in Rosetta.

@srid srid closed this Mar 22, 2024
@srid srid deleted the fixed-intel-build branch March 22, 2024 16:31
@srid srid mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid srid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1vipulgupta @srid